chore: update port configuration and improve connection logic #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yulingtianxia
changed the title
yulingtianxia
force-pushed
the
patch-1
branch
from
5a01fe4 to
686674c
Compare
- Change default port from 5000 to 5001 to avoid conflicts with macOS services (e.g., AirTunes) - Integrate new DroidAgent config API using config_manager - Improve device connection logic to properly handle emulators and network devices - Add timeout handling and error handling mechanisms - Support custom API base URL configuration via --api-base flag - Update README documentation with additional configuration options and examples - Update dependency lock file
yulingtianxia
force-pushed
the
patch-1
branch
from
686674c to
254ca7c
Compare
- Introduced a new --config option to allow loading parameters from a DroidRun config.yaml file, overriding CLI parameters. - Updated LLM loading logic to differentiate between using CLI parameters and config file settings. - Enhanced timeout handling for Browser tasks to accommodate increased complexity. - Improved agent initialization to utilize provided config or fallback to CLI parameters for backward compatibility.
yulingtianxia
force-pushed
the
patch-1
branch
from
46733f9 to
e8138dd
Compare
|
+1 on fixing the missing Gentle bump @Timo972 ! Happy to open a PR to fix only these specific issues, but this one seems like a good contribution 👍 |
- Updated boot_environment and related functions to be asynchronous, improving responsiveness and performance. - Changed device connection and command execution to use async methods from async_adbutils. - Added adbutils dependency to pyproject.toml for async support. - Enhanced error handling during environment setup and task execution.
- Introduced a 2-second delay to allow the UI to stabilize after the agent completes its task, ensuring accurate task state evaluation. - Added similar stabilization wait in the timeout handling case to maintain consistency in scoring.
yulingtianxia
force-pushed
the
patch-1
branch
from
c1c5f72 to
18cd966
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified Files & Changes
eval/cli.py & eval/env/client.py
• Changed default --env-url from http://localhost:5000 to http://localhost:5001
• Added --api-base flag for custom LLM API endpoints
eval/env/boot.py
• Fixed device connection logic: skip adb.connect() for emulator serials (emulator-*), only connect network devices
• Added device validation and accessibility check
• Improved error handling with proper RuntimeError messages
eval/runner.py
• Migrated to new DroidAgent configuration API using DroidrunConfig, AgentConfig, ManagerConfig, ExecutorConfig
• Added timeout handling: catches TimeoutError and generates proper result with error reason
• Updated agent initialization to use structured config objects
eval/tracker.py
• Enhanced result parsing to support both dict and object formats
• Improved reasoning field resolution with proper fallback
README.md
• Updated CLI examples and documentation
• Added configuration options for LLM providers, task selection, performance tuning, and advanced features
Problems Solved